Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug: adding back prefix in service group creation #1339

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rexf
Copy link

@rexf rexf commented Nov 5, 2024

fix bug: adding back prefix in service group creation

Currently, the prefix will be missing if we are creating group from group.
e.g.

let sg = service.group("level1");
sg.endpoint("endpoint1") ==> we can expect to see "level1.endpoint1"

let g2 = sg.group("level2:);
g2.endpoint("endpoint2") ==> now we will see "level2.endpoint2"

this patch is to fix and apply the prefix for the g2 endpoint such that the topic will become
level1.level2.endpoint2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant